forward to analysis page (missing analysis) #1320
Merged
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jstucke
commented
Dec 16, 2024
•
jstucke
commented
- if an analysis did not run for a file, the user is directed to an error page (a page empty except for an error message)
- this is not helpful, so this PR changes this behavior as follows: Instead of showing the error page the user is forwarded back to the analysis page (without selected plugin) and the error is displayed as flash message
- steps to (re)produce the error: Go to some file in a FW, run a "single file analysis" and go back to the root object through the link in the "general information" section
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1320 +/- ##
==========================================
- Coverage 92.42% 91.90% -0.53%
==========================================
Files 379 378 -1
Lines 23661 21097 -2564
==========================================
- Hits 21869 19389 -2480
+ Misses 1792 1708 -84 ☔ View full report in Codecov by Sentry. |
|
Please put the PR description in the commit message. |
instead of showing the error page * if an analysis did not run for a file, the user is directed to an error page (a page empty except for an error message) * this is not helpful, so this PR changes this behavior as follows: Instead of showing the error page the user is forwarded back to the analysis page (without selected plugin) and the error is displayed as flash message * steps to (re)produce the error: Go to some file in a FW, run a "single file analysis" and go back to the root object through the link in the "general information" section
jstucke
force-pushed
the
missing-analysis-fix
branch
from
e52b4b5 to
305f013
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.